Prevent error in github action if no benchmarks are run. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have a github action that runs benchmarks when a format is added or edited.
The action errors out when base formats are edited because the "Run benchmark tests" step is skipped but the "Concatenate results" step is still looking for
benchmark_results_*.txtfile/s to report. See for example: https://github.com/chorus-ai/chorus_waveform/actions/runs/11615143978/job/32344989477This pull request should fix the problem, by wrapping the
cat benchmark_results_*.txtstep in an if clause. If the file doesn't exist, we now report "No benchmarks were run.", instead of raising an error.